search

grafana / pyroscope-java

pyroscope java integration
Apache License 2.0
72 stars 31 forks source link

Add ability to explicitly set tags #57

Closed petethepig closed 1 year ago

petethepig commented 1 year ago

Currently the only way is via app_name (e.g app{foo=bar}), but we should make it more explicit, e.g via a separate variable.

korniltsev commented 1 year ago

Also java agent is unaware of it and if you specify app name as app{foo=bar} and also Pyroscope.setStaticLabel(mapOf("fiz", "baz")) it will probably try to ingest app{foo=bar}{fiz=baz} and fail. When we have an explicit variable, should we still support tags with app name or it should be prohibited?

korniltsev commented 1 year ago

Also right now for name app{foo=bar} and collapsed format, the final app name is app But for app{foo=bar} and jfr format app.itimer

Strange

korniltsev commented 1 year ago

Fixed in https://github.com/pyroscope-io/pyroscope-java/pull/58