search

grafana / pyroscope-nodejs

Pyroscope NodeJS integration
Apache License 2.0
27 stars 21 forks source link

feat: updated configuration vars to be consistent with other agents #14

Closed shaleynikov closed 2 years ago

shaleynikov commented 2 years ago

Depends on #13

shaleynikov commented 2 years ago

Admittedly I just looked at go, but from what I saw the env var integration is done at the application level (ie the application expects an appName, how the application figures that out via envvar/config file is up to the application), so I don't quite get why we are doing it here.

Well, other agrents, does it differently. Like java is completely configured via env vars. User is still able to configure on app level, just left a possibility to use env vars. I can delete if it isn't consistent