Closed k4kratik closed 1 year ago
@kolesnikovae - Do we need to reduce the default value of SAMPLING_DURATION_MS
? I tried with 1000ms and all test passed.
- RE: tests, I think with approach # 1 you can just pass a custom interval to
Pyroscope.init
. But in any case, I think it's still possible to overwriteprocess.env
vars dynamically before starting the test.
Hi @eh-am, thanks for the review. I ran test with SAMPLING_DURATION_MS 1000ms and it passed all tests.
.
Thank you @kolesnikovae 👍🏻
Adresses #21
I checked and found out these critical parameters are not configurable. Also, their name and use was very confusing.
So I renamed variable
INTERVAL
&SAMPLERATE
toSAMPLING_INTERVAL_MS
(default - 10ms) &SAMPLING_DURATION_MS
(Default - 1000ms).hope this helps. Shout out to @kolesnikovae🎖️ & @eh-am🎖️ for the help and support.