Closed ben-xD closed 3 months ago
there is a PR https://github.com/grafana/pyroscope-nodejs/pull/19
@ben-xD @korniltsev Any progress on this matter? The linked PR only adds datadog/pprof
as a dependency, while the original pprof
is still present in package.json
. Installing pyroscope-nodejs
in the app still requires heavy dependencies (python
, gcc
, make
) for higher Node.js versions.
The PR was merged and released. Does it work with the latest release?
It does not work for me. The pprof
dependency is still there. When building the app with pyroscope-nodejs
in the latest version, I get errors in CI related to missing make
tool - it tries building the pprof
dependency.
As of v0.3.8 we should no longer use the pprof
dependency now
@bzurkowski Thanks for reporting this, if you find more problems, please let us know.
https://www.npmjs.com/package/@datadog/pprof (1,788,492 weekly downloads) is used a lot more than https://www.npmjs.com/package/pprof (142,535 weekly downloads).
It's also difficult to use the old
pprof
, because there are no binaries available compatible with newer versions of Node. Therefore, installing it will use node-gyp to build pprof, which requirespython
andmake
to be installed.@datadog/pprof
really easily (within seconds).Is it possible to switch to consider if @datadog/pprof is better, and switch to it?