grafana / pyroscope-nodejs

Pyroscope NodeJS integration
Apache License 2.0
27 stars 21 forks source link

feat: `/debug/pprof/allocs` instead of `/debug/pprof/heap` #36

Closed jjangga0214 closed 3 months ago

jjangga0214 commented 11 months ago

Hi!

It seems my Pyroscope scraps /debug/pprof/allocs instead of /debug/pprof/heap. (I am new to Pyroscope)

Then shouldn't the express middleware handle /debug/pprof/allocs?

Thanks.

simonswine commented 3 months ago

I do think the pulling end needs to be fixed instead. As for nodejs we don't have memory allocation statistics.

jjangga0214 commented 3 months ago

@simonswine Got it. Is it a bug of the pulling end, or a thing that should be configured from the pulling end? Thanks.