grafana / pyroscope-nodejs

Pyroscope NodeJS integration
Apache License 2.0
26 stars 18 forks source link

bug: heap profiling doesn't use sourcemaps #64

Closed Bruno-DaSilva closed 2 months ago

Bruno-DaSilva commented 4 months ago

The heap profiler doesn't use the sourcemapper parameter passed in on init https://github.com/grafana/pyroscope-nodejs/blob/main/src/profilers/heap-profiler.ts#L31

despite being available as an argument in the heap.profile(sourcemapper) method https://github.com/DataDog/pprof-nodejs/blob/v4.x/ts/src/heap-profiler.ts#L56

As a result, we currently only see the raw js stacktraces in the heap profiles.