Revert "Add ui tests for CLI (#95)"

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.

Apache License 2.0

132 stars 22 forks source link

Revert "Add ui tests for CLI (#95)" #106

Closed korniltsev closed 1 year ago

korniltsev commented 1 year ago

This reverts commit 669304aa6392806d74f3794597f9ccda500cde67.

hi-rustin commented 1 year ago

Can I ask does this change broken anything? Why do we need to revert it?

hi-rustin commented 1 year ago

If you want to update the snapshot, you can run the tests with TRYCMD=overwrite.

You can find the tips in the CI log.

Testing tests/cli-ui/pyroscope_cli_help_cmd_stdout.toml ... ok
Testing tests/cli-ui/pyroscope_cli_help_flag_stdout.toml ... ok
Update snapshots with `TRYCMD=overwrite`
Debug output with `TRYCMD=dump`

The CI failed because the UI changed, the change introduced by https://github.com/grafana/pyroscope-rs/commit/64a23e0d4c2179608c53832975421d9a4f97fdb8.