Avoid pulling in `clap` crate by the library

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.

Apache License 2.0

132 stars 22 forks source link

Avoid pulling in `clap` crate by the library #140

Closed mati865 closed 5 months ago

mati865 commented 6 months ago

names has made questionable decision to depend on clap by the default which brings unnecessary dependencies for the library users: https://github.com/fnichol/names/blob/b5023b03e2339bf6e860bdcef20557ab81f3ec55/Cargo.toml#L21

CLAassistant commented 6 months ago

All committers have signed the CLA.

CLAassistant commented 6 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

korniltsev commented 5 months ago

CI was broken before. Im merging as is

mati865 commented 5 months ago

Thanks