grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.
Apache License 2.0
132 stars 22 forks source link

Clap feature tweaking #141

Closed CosmicHorrorDev closed 6 months ago

CosmicHorrorDev commented 6 months ago

(Context: sniffing out lingering sources of old clap version downloads)

inferno and names are both bin+lib crates that both use a default feature for the CLI related dependencies. Currently there are still some dependencies that are unconditionally pulling in clap for binary-related things even when using it as a library. I've already opened issues on both of the ones I noticed

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CosmicHorrorDev commented 6 months ago

I didn't notice that this would require signing a CLA, but I'd rather not. Apologies for the noise