Ruby 3.3 support with rbspy

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.

Apache License 2.0

132 stars 22 forks source link

Ruby 3.3 support with rbspy #145

Closed tomasv closed 2 months ago

tomasv commented 4 months ago

Hey,

The bundled version of rbspy is 0.17 as of this moment, it would be great to upgrade to 0.19.1 which supports Ruby 3.3 and has some fixes with multithreaded applications.

Thanks

ndguarino commented 3 months ago

Tacking onto this, Ruby 3.2.3 is also affected and fixed in the same rbspy version.

2024-03-07 10:12:47 thread '<unnamed>' panicked at 'Ruby version not supported yet: 3.2.3. In the meantime, we suggest trying `--force-version <prior version>`.', /app/.cargo/registry/src/github.com-1ecc6299db9ec823/pyroscope-rbspy-oncpu-0.17.0/src/core/ruby_version.rs:1818:14
2024-03-07 10:12:47 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace