search

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.
Apache License 2.0
132 stars 22 forks source link

Update self-hosted runner labels to be more specific #166

Closed guicaulada closed 1 month ago

guicaulada commented 1 month ago

This pull request updates the runner labels on workflows that are running self-hosted runners to use more specific and explicit labels, the current labels can be interpreted wrongly by the system resulting in dev instances picking up jobs for prod instances.

Part of https://github.com/grafana/deployment_tools/issues/142178 Part of https://github.com/grafana/deployment_tools/issues/142917

Related https://github.com/grafana/pyroscope-dotnet/pull/64

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

guicaulada commented 1 month ago

Apparently jobs are not being picked up, I'm looking into it.

guicaulada commented 1 month ago

Why does this repository doesn't have access to organization wide self-hosted runners?

Grafana org runners should be showing up here: https://github.com/grafana/pyroscope-rs/actions/runners?tab=self-hosted

guicaulada commented 1 month ago

Looking into that now.

guicaulada commented 1 month ago

Apparently we will postpone this for public repositories.