search

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.
Apache License 2.0
132 stars 22 forks source link

python: oncpu is the wrong way around #58

Open garthwilliamson opened 1 year ago

garthwilliamson commented 1 year ago

Describe the bug you encountered:

oncpu: false still only shows cpu

What did you expect to happen instead?

it should show idle too

How did you install pyroscope-rs?

from python

https://github.com/pyroscope-io/pyroscope-rs/blob/main/pyroscope_backends/pyroscope_pyspy/src/lib.rs#L256 should be inverted - include idle when it's false.

the comment at the top of the file is wrong too

Bruno-DaSilva commented 11 months ago

ran into this just now as well :)