search

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.
Apache License 2.0
132 stars 22 forks source link

Add python windows #67 #68

Closed mjmdavis closed 1 year ago

mjmdavis commented 1 year ago

closes #67 I am looking into how to add support for Python on Windows.

The main issue seems to be a platform dependent type in a transitive dependency of pyroscope_pyspy. I'm not sure what the best method for addressing this is but I went with adding a direct dependency and pulling the type in from there.

mjmdavis commented 1 year ago

I have the windows build going now. I need to try installing it and see if it works.

mjmdavis commented 1 year ago

So, it's working on windows. I am able to send telemetry to https://pyroscope.cloud and everything :)

korniltsev commented 1 year ago

Hi. Thanks a lot for contribution and sorry for long response. I'l merge it now. I am probably going to remove the ci-ffi-python-windows.yml and keep the ci-ffi-python.yml. Please let me know if I misunderstood the intent of the windows file. I am also going to add it to the publish gh action.

Thanks a lot!