search

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.
Apache License 2.0
132 stars 22 forks source link

Not working with Ruby 3.2.0 and higher #80

Closed AnotherRegularDude closed 1 year ago

AnotherRegularDude commented 1 year ago

Describe the bug you encountered:

When starting a server on Ruby 3.2, pyroscope writes an error in the logs that the current version of Ruby is not supported: rails thread '<unnamed>' panicked at 'The target process's Ruby version is not supported yet. In the meantime, you can try using --force-version 3.2.0 In this case, the application works as expected, except that nothing is sent to the pyroscope server. ...

What did you expect to happen instead?

Pyroscope works with Ruby version 3.2.

...

How did you install pyroscope-rs?

Using ruby gem from there https://rubygems.org/gems/pyroscope

Pyroscope gem version: 0.5.1 Ruby version: 3.2.0 OS: Debian Also, Ruby running with enabled JIT.

korniltsev commented 1 year ago

Yeah, I will update rbspy shortly

korniltsev commented 1 year ago

or not so shortly.. I will need to figure out how to update our rbspy fork. I will keep you updated.

AnotherRegularDude commented 1 year ago

Hi I see that the PR is merged =) Does it make sense now to build a gem from a main and build binary in our CI? Or you'll soon push the gem to rubygems.

korniltsev commented 1 year ago

it is building right now https://github.com/pyroscope-io/pyroscope-rs/actions/runs/4230535373 waiting for macos runners to pick up the job

AnotherRegularDude commented 1 year ago

Oh, I see now Thank you!

korniltsev commented 1 year ago

fixed in 0.5.2 gem

AnotherRegularDude commented 1 year ago

Working perfectly

Thank you =)