Bump the clap from 3.x to 4.x

grafana / pyroscope-rs

Pyroscope Profiler for Rust. Profile your Rust applications.

Apache License 2.0

132 stars 22 forks source link

Bump the clap from 3.x to 4.x #92

Closed hi-rustin closed 6 months ago

hi-rustin commented 1 year ago

Clap was released for a while. I think maybe it would be nice to upgrade the clap from 3.x to 4.x for the pyroscope CLI.

If you think it makes sense I can help to add UI tests for CLI and bump the clap version.

korniltsev commented 1 year ago

Does it require to update rust toolchain? I would like to keep 1.63 for as long as possible because 1.64 bumps glibc dependency, preventing running pyroscope-rs on ridiculously old systems for no good reason for pyroscope. If it does not require to update toolchain - I am open to upgrade

hi-rustin commented 1 year ago

If it does not require to update toolchain - I am open to upgrade

I think we can at least we can get 4.0 without updating the toolchain.