search

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.79k stars 583 forks source link

Replace rgb(112, 219, 237) in palette for something darker #1049

Closed eh-am closed 2 years ago

eh-am commented 2 years ago

image

The contrast is not very good As you can see the contrast is not very good https://github.com/pyroscope-io/pyroscope/blob/main/packages/pyroscope-flamegraph/src/FlameGraph/FlameGraphComponent/colorPalette.ts#L34

Plus it's a good idea to have a look at every single color in the palette.

eh-am commented 2 years ago

The problem I see here is that the same color is used in both the table and the flamegraph, but the text color is white in the former and black in the latter.

image

We can't just make the text black in both, since you may have cases like the following, where the background is not 100% width. image

eh-am commented 2 years ago

Reopning this since the current solution looks weird for diff view Screen Shot 2022-04-25 at 3 00 38 PM

deepto98 commented 2 years ago

Can I pick this up?