grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.79k stars 583 forks source link

Support Jaeger Trace visualization with Flamegraph #1170

Closed Rperry2174 closed 2 years ago

Rperry2174 commented 2 years ago

There are two issues in Jaeger repo:

About visualizing trace data in Flamegraph form. Now that we have our @pyroscope/flamegraph npm package we could potentially make a slight modification to the code for the FlamegraphRenderer that would allow for us to:

  1. Transform trace data into a format that the flamegraph understands
  2. Visualize the trace data as a flamegraph

Worth noting that this tool: https://github.com/symbiont-io/jaeger-flamegraph takes a trace dump and turns it into a flamegraph.

I think the steps are:

image

For now we should do this in the pyroscope/jaeger-ui repo so we can test it out and see what it looks like and then later we will share with the jaeger team to get it merged upstream.

eh-am commented 2 years ago

Related https://github.com/pyroscope-io/pyroscope/issues/172

Rperry2174 commented 2 years ago

Note: They also have a "compare" page which calculates a diff. It would be cool if we could support that as well, but I think that would require us to move some of our go code into jaeger (or modularize it somehow)

image
Rperry2174 commented 2 years ago

Completed in #1233 see example screenshotted below here

image