grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.67k stars 578 forks source link

Data Gap in Pyroscope #3081

Open skundu1234 opened 4 months ago

skundu1234 commented 4 months ago

Is your feature request related to a problem? Please describe.

We have kept this but after retention-policy-enforcement-interval as 8 hours but its taking more than 1 hour to get data from object storage when we use querier.query-store-after as 35 min and even less than that.Is there any configuration we are missing .We dont want to see data gap during retention-policy-enforcement-interval.

pyroscopedb.retention-policy-enforcement-interval: 8h  # 4h
pyroscopedb.max-block-duration: 30m
pyroscopedb.retention-policy-min-free-disk-gb: 10
pyroscopedb.retention-policy-min-disk-available-percentage: 0.990
querier.query-store-after: 35m

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

querier.query-store-after: 35m this CLI is not working properly.When Query should be coming from object storage and data is present as well in object storage.We are using GCS bucket.

Describe the solution you'd like

I want to make it work querier.query-store-after: 35m so no data gap will be there.

A clear and concise description of what you want to happen.

There should not be data gap after 35 mins buts its taking much time on its own.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

I have added screenshot.

pyroscope_restart gcp_bucket_storage
kolesnikovae commented 4 months ago

Could you please remove the settings below and check if the problem persists?

pyroscopedb.retention-policy-enforcement-interval: 8h  # 4h
querier.query-store-after: 35m

querier.query-store-after: 35m is too short. Given that the pyroscopedb.max-block-duration is set to 30m, store-gateways do not have enough time to pick up the newly uploaded blocks. There is an option to increase the frequency of block discovery in store-gateways, but I would recommend setting querier.query-store-after to 1h at least