Create a stub mapping for truncated nodes

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code

https://grafana.com/oss/pyroscope/

GNU Affero General Public License v3.0

10.08k stars 609 forks source link

Create a stub mapping for truncated nodes #3196

Open kolesnikovae opened 7 months ago

kolesnikovae commented 7 months ago

When a pprof profile is truncated, we replace the removed nodes with a shared "stub" location (named "other") that references the default mapping (ID == 1), which may lead to ambiguity. Instead, a shared "stub" mapping should be created (probably, even if the profile already has a "stub" mapping created at ingestion).

simonswine commented 7 months ago

Yes I do agree, esp. once we want to attach more information (OTEL spec) to the mapping we should be careful what belongs together or not.