grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.69k stars 578 forks source link

fix: deprecate pprof MergeNoClone #3251

Closed kolesnikovae closed 2 months ago

kolesnikovae commented 2 months ago

pprof.MergeNoClone has particularly tricky semantics which is very easy to misuse: specifically, it may cause duplication of samples. Although the function is significantly cheaper than pprof.Merge and can be fixed, I think it's better to deprecate it in favour of safety