search

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.66k stars 577 forks source link

Python default in source code is 100 #3286

Closed danleyb2 closed 1 month ago

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

korniltsev commented 2 months ago

https://github.com/grafana/alloy/blob/12e52a8e5062d2c0b054ec97f6f399ccc1f46ce1/internal/component/pyroscope/ebpf/ebpf_linux.go#L75

danleyb2 commented 1 month ago

@korniltsev From published PYPI package https://pypi-browser.org/package/pyroscope-io/pyroscope_io-0.8.7-py2.py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl/pyroscope/__init__.py#L18

korniltsev commented 1 month ago

this PR changes documentation for ebpf profiler and the latter link you share is for python pip package profiler They are not the same

danleyb2 commented 1 month ago

@korniltsev well, my edit link came from this docs page: https://grafana.com/docs/pyroscope/latest/configure-client/language-sdks/python/

korniltsev commented 1 month ago

This is the link you are looking for https://github.com/grafana/pyroscope/blob/main/docs/sources/configure-client/language-sdks/python.md

danleyb2 commented 1 month ago

@korniltsev In that case docs are okay