grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.65k stars 576 forks source link

Fix link to spanprofiler #3311

Closed iblancasa closed 1 month ago

iblancasa commented 1 month ago

Just fix the link for the spanprofiler application in the examples.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

simonswine commented 1 month ago

Thanks for fixing this ❤️

github-actions[bot] commented 1 month ago

Hello @simonswine! Backport pull requests need to be either:

Please, if the current pull request addresses a bug fix, label it with the type/bug label. If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label. If the pull request modifies CI behaviour, please add the type/ci label. If none of the above applies, please consider removing the backport label and target the next major/minor release. Thanks!

github-actions[bot] commented 1 month ago

This PR must be merged before a backport PR will be created.

github-actions[bot] commented 1 month ago

The backport to release/v1.5 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3311-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b79c573f8121fa27677e997983e2463b581e861a

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3311-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3311 --json body --template 'Backport b79c573f8121fa27677e997983e2463b581e861a from #3311{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.5] Fix link to spanprofiler' --body-file - --label 'type/docs' --label 'backport' --base release/v1.5 --milestone release/v1.5 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3311-to-release/v1.5

# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3311-to-release/v1.5`.

# Remove the local backport branch
git switch main
git branch -D backport-3311-to-release/v1.5