search

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.65k stars 576 forks source link

profiles from python sdk have -1 as line number #3336

Closed korniltsev closed 3 weeks ago

korniltsev commented 1 month ago

The underlying pprof from pyspy has line numbers

https://github.com/grafana/pyroscope/blob/7faadde03a8035a000fa4f184547548eeea42016/pkg/og/convert/pprof/profile.go#L256

Suggested options to fix:

  1. properly render line number on frontend
  2. rewrite pprof to include line number in the Function.Name