search

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.97k stars 597 forks source link

fix: `group by` with enforced label order #3352

Closed kolesnikovae closed 3 months ago

kolesnikovae commented 3 months ago

The recently added series order optimization (#3345) has a bug, leading to invalid group by results. The cause is that BytesWithLabels assumed the standard order. The requirement has been relaxed: this makes the function less efficient, but not to the extent that it is a concern.

Also cleaned up the package a bit.