search

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.64k stars 574 forks source link

`helm install --wait` results in a failed deployment #3385

Open aleks-p opened 1 week ago

aleks-p commented 1 week ago

The Helm installation instructions for the microservice mode suggest the following command:

curl -Lo values-micro-services.yaml https://raw.githubusercontent.com/grafana/pyroscope/main/operations/pyroscope/helm/pyroscope/values-micro-services.yaml
helm -n pyroscope-test install pyroscope grafana/pyroscope --values values-micro-services.yaml

A commonly used flag for helm install is --wait, which makes sure all pods are up and ready before the command exits, waiting for X minutes (configurable via the --timeout flag). If users use the --wait flag directly or via a helm wrapper, the Pyroscope installation will currently fail. This is because the bucket is created in Minio after helm install completes, which in this case will not happen since store-gateways need a bucket to get into the ready state.