grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
9.98k stars 598 forks source link

Reject queries without a time range #3395

Closed bryanhuhta closed 3 months ago

bryanhuhta commented 3 months ago

In https://github.com/grafana/explore-profiles/pull/15, I ran across a bug where the UI was sending queries without a time range. It was a little tricky to track down because Pyroscope would respond with a success status code, but an empty payload. This made me wonder if there was a bug in Pyroscope's query logic.

I think we should classify queries with no time range an error. I don't know of any use cases in which we want to have a time range, but allow it to be optionally provided.