Provide debug info in docker images

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code

https://grafana.com/oss/pyroscope/

GNU Affero General Public License v3.0

9.86k stars 586 forks source link

Provide debug info in docker images #3407

Open simonswine opened 2 months ago

simonswine commented 2 months ago

Today I had found it fairly limiting not being able to use dlv in one of our production instances.

I propose to either:

Remove stripping of debug infos by default
Provide separate .debug files with the infos attached (https://github.com/kubernetes/kubernetes/issues/73986#issuecomment-807821958)

korniltsev commented 2 months ago

I was under impression it does not work well on non debug (i.e. no -gcflags="all=-N -l" ) binaries Did you ever use it on non debug binaries? I like the idea of having separate debug files. In the past I've deployed a custom debug image couple of times in gl dev cluster for debugger (gdb :smile: ) usage purposes.

korniltsev commented 1 month ago

Maybe this should be a separate issue, but I'l just dump it here. Just had some ideas for debugger experience improvements:

make docker-image/pyroscope/build-debug could add -gcflags="all=-N -l" for improved debugging experience
Could be nice to optionally have make deploy-micro-services / make deploy use debug docker images
Could be nice to have a helm knob to expose delve 40000 port