search

grafana / pyroscope

Continuous Profiling Platform. Debug performance issues down to a single line of code
https://grafana.com/oss/pyroscope/
GNU Affero General Public License v3.0
10.13k stars 614 forks source link

fix (v2): add support for ProfileTypes requests #3541

Closed aleks-p closed 2 months ago

aleks-p commented 2 months ago

ProfileTypes is still used for datasource health checks (see this), therefore we need to have it supported in the v2 read path as well. Adding a simple implementation that collects profile types from the block metadata datasets.

TODO: add unit test

aleks-p commented 2 months ago

I wonder if we should ask frontend to switch to some other method for healthcheck. I susupect this is the only usage of the method. I had the same issue during POC

I agree and I can make the switch to a different method in Grafana. Since it is a public API though and would be used in older Grafana versions we can only mark it as deprecated for now but not remove it.