Closed zmj64351508 closed 2 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Thank you for the contribution. I left some comments.
Thank you for the contribution! I've created an issue to add an integration tests for these cases. Feel free to submit a PR if you want to https://github.com/grafana/pyroscope/issues/3588
I'm porting alloy/pyroscope to the mobile phone running Android 14. And I found some issues:
The config
CONFIG_PID_NS
is not set in standard Android kernel, which means /proc/self/ns/pid is not exist and alloy will exit with failure. The first commit fixed this issue by ignoring error when /proc/self/ns/pid doesn't exist.When kernel modules or bpf programs are dynamic loaded from userspace after kernel boot, the address in /proc/kallsyms may be unordered, which causes the origin code find wrong symbol. The second commit fixed this issue by sorting the symbol by address. Here's an example for such /proc/kallsyms: