search

grafana / rollout-operator

Kubernetes Rollout Operator
Apache License 2.0
132 stars 17 forks source link

Expose some HTTP server metrics like per-route request latency #100

Closed charleskorn closed 9 months ago

charleskorn commented 9 months ago

This PR adds some basic metrics for incoming HTTP requests, like per-route latency and status codes.

This uses the instrumentation from dskit, which required changing the HTTP router from a vanilla net/http.ServeMux to a github.com/gorilla/mux.Router. I'm not sure if we want to take a dependency on dskit here - open to feedback or other suggestions.

pracucci commented 9 months ago

I'm not sure if we want to take a dependency on dskit here - open to feedback or other suggestions.

Adding dskit dependency looks fine to me. That's why we have a shared library for common stuff between our projects.