search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
134 stars 20 forks source link

scene: users with view role can move panels #203

Closed baur closed 1 year ago

baur commented 1 year ago

What went wrong?

What happened:

users with view role can move panels

What did you expect to happen:

maybe this is scene feature?

How do we reproduce it?

just move any panel on scene mode

What Grafana version are you using?

v10.1.0-117102pre

Optional Questions:

Is the bug inside a Dashboard Panel?

No response

Grafana Platform?

A downloaded binary

User's OS?

Windows11

User's Browser?

Chrome 113

Is this a Regression?

None

Are Datasources involved?

No response

Anything else to add?

No response

torkelo commented 1 year ago

@baur in scenes you as a developer have to control this via the isDraggable property on SceneGridLayout (it is not something the scenes framework is responsible for)

isDraggable should maybe not default to true however, @dprokop what do you think?

dprokop commented 1 year ago

isDraggable should maybe not default to true however, @dprokop what do you think?

I agree. The default behavior in apps should be non draggable as the layout is not persisted anyhow unless developer implements something on top of scenes.

torkelo commented 1 year ago

Fixed by https://github.com/grafana/scenes/pull/246