search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

AdHoc filter: Don't render label twice when used as a variable #580

Closed dprokop closed 9 months ago

dprokop commented 9 months ago

A hacky way to make sure filter's control label ain't rendered twice (see https://github.com/grafana/grafana/pull/81318#issuecomment-1932233163).

This is until we get rid of AdhocFilterSet and replace it with only a variable as we did with group by variable.

📦 Published PR as canary version: 2.6.5--canary.580.7828999283.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes@2.6.5--canary.580.7828999283.0 # or yarn add @grafana/scenes@2.6.5--canary.580.7828999283.0 ```
dprokop commented 9 months ago

@torkelo - actually I'm closing this one, talked with @ivanortegaalba and I think we can just disable the label config in core for the adhoc variable and rely on the adhoc filter set built-in label. Maybe not the best, but at least we can avoid this hacking.