search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

VariableDependencyConfig: Fixes support for explicit dependencies and scanned dependencies #630

Closed torkelo closed 8 months ago

torkelo commented 8 months ago

Missed the if/else logic in https://github.com/grafana/scenes/pull/598

We need to support both explicit and scanned dependencies

Fixes #629

domasx2 commented 8 months ago

@ivanortegaalba added the else deliberately to fix some other issue though https://github.com/grafana/grafana/pull/81318

torkelo commented 8 months ago

@domasx2 I do not think that is needed, was wrong way to fix it. We should not scan child scene objects. We changed so that statePaths are now required for state to be scanned. So think https://github.com/grafana/scenes/pull/599 should fix that (requiring an explict wildcard for all state to be scanned, something I would think will be very uncommon), and we also have https://github.com/grafana/scenes/pull/597 as a extra safety measure

grafanabot commented 8 months ago

:rocket: PR was released in v3.9.1 :rocket: