search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

Annotations: Don't always execute annotations on activate #635

Closed torkelo closed 7 months ago

torkelo commented 8 months ago

Noticed that we always execute annotations on activate (even when we already have data, coming back to a scene).

Changing this logic a bit so we do not always run on activate if we have data. We should probabaly add a check if time range is stale as well and run query then but leaving that for another time.

dprokop commented 8 months ago

@torkelo - wondering if this is still relevant given https://github.com/grafana/scenes/pull/640?

torkelo commented 8 months ago

@dprokop not sure, will check after that one is merged

torkelo commented 7 months ago

@dprokop think this is still relevant, still see annotation queries always being executed when you leave dashboard settings

grafanabot commented 7 months ago

:rocket: PR was released in v4.9.0 :rocket: