AdHoc Filters: Allow custom value

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.

https://grafana.com/developers/scenes

Apache License 2.0

141 stars 21 forks source link

AdHoc Filters: Allow custom value #670

Closed ashharrison90 closed 7 months ago

ashharrison90 commented 7 months ago

allow specifying a custom value as the adhoc filter value
adds a unit test to ensure we preserve this behaviour

Fixes https://github.com/grafana/grafana/issues/85070

📦 Published PR as canary version: 4.3.0--canary.670.8538200720.0

:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes@4.3.0--canary.670.8538200720.0 # or yarn add @grafana/scenes@4.3.0--canary.670.8538200720.0 ```

dprokop commented 7 months ago

Looks good. Question is if reloading the page with the custom value in URL will allow the value to be preserved? I think it's essential to make sure the custom value is persisted across reloads.

ashharrison90 commented 7 months ago

Looks good. Question is if reloading the page with the custom value in URL will allow the value to be preserved? I think it's essential to make sure the custom value is persisted across reloads.

yep, reloading the page correctly restores the custom value 👍

ashharrison90 commented 7 months ago

@dprokop i don't think there's a prop on the component that would let us do that. i know exactly what you mean, that could get annoying. i'm sure we were discussing this in frontend platform the other day. i'll do some searching

grafanabot commented 7 months ago

:rocket: PR was released in v4.3.0 :rocket: