Closed ashharrison90 closed 6 months ago
@ashharrison90 - I've made a couple of changes to this PR. In particular:
isLazy
to SceneVariableState
. Thanks to that and the change in SceneVariableSet the GroupBy values are not fetched when the picker renders. Overall this property needs to be added to other variables as well, but this is a bit bigger endeavour and won't address it here. We are tracking it in https://github.com/grafana/scenes/issues/214@torkelo - I would appreciate your eyes on this too, as I'm touching on the isLazy
we discussed and introducing it in the interface for the future use.
:rocket: PR was released in v4.11.2
:rocket:
delivered in core with https://github.com/grafana/grafana/pull/86671
i think this does what we want, but leaving as draft for now to check the approach before adding tests etc
what this does:
VariableValueSelectMulti
isFetchingOptions
andisOptionsOpen
logic controlled byonOpenMenu
/onCloseMenu
model.validateAndUpdate()
some questions:
VariableValueSelectMulti
🤔Fixes #686
📦 Published PR as canary version:
4.11.2--canary.687.8737546972.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes@4.11.2--canary.687.8737546972.0 # or yarn add @grafana/scenes@4.11.2--canary.687.8737546972.0 ```