search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

VizPanel: Fixes issue updating instanceState #702

Closed torkelo closed 6 months ago

torkelo commented 6 months ago

Trying to fix https://github.com/grafana/grafana/issues/86554

Also changing / skipping using instanceState for legacyPanelId as this is a bit problematic as this state is really reserved to only be used by the panel plugin so for Grafana to use it causes issues (we have to make sure we preserve legacyPanelId when we handle onInstanceStateChange.

I am tempted to just add legacyPanelId to VizPanel state (instead of parsing it from key) but not sure.

📦 Published PR as canary version: 4.12.0--canary.702.8784713837.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes@4.12.0--canary.702.8784713837.0 # or yarn add @grafana/scenes@4.12.0--canary.702.8784713837.0 ```
grafanabot commented 6 months ago

:rocket: PR was released in v4.12.0 :rocket: