search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

Typescript: Enable strict mode #728

Closed torkelo closed 6 months ago

torkelo commented 6 months ago

Should fix some of the errors that show up when yarn linking into main repo

dprokop commented 6 months ago

hm, i see 94 errors when linking main and 94 errors when linking this branch. Are you sure this brings any improvement?

Sergej-Vlasov commented 6 months ago

same result here 94 errors before and after. Strict mode can be annoying with extra errors but no additional errors here so would be for enabling strict mode

torkelo commented 6 months ago

@dprokop well it fixes a few strict errors (see the ones fixed in PR) so it does something, not sure what else to enable

torkelo commented 6 months ago

@dprokop is there any argument to not extend tsconfig (Which has the important strict: true option)

torkelo commented 6 months ago

Strict mode can be annoying with extra errors but no additional errors here so would be for enabling strict mode

@Sergej-Vlasov not sure what your mean :)

Sergej-Vlasov commented 6 months ago

Strict mode can be annoying with extra errors but no additional errors here so would be for enabling strict mode

@Sergej-Vlasov not sure what your mean :)

Sorry, meant to say that I support enabling strict mode in short 😅

grafanabot commented 6 months ago

:rocket: PR was released in v4.20.0 :rocket: