search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

Variables: Prioritize showing adhoc variable key and operator #750

Closed oscarkilhed closed 5 months ago

oscarkilhed commented 5 months ago

When the value of the adhoc filter gets long, you can't see the key and operator, which are arguably more important than showing a few more characters of the already truncated value.

Before: image

After: image

Fixes: https://github.com/grafana/grafana/issues/88328

dprokop commented 5 months ago

@oscarkilhed - can we also add some max width constraint to the value input? While editing it (entering custom value) it can push the time controls outside of the container:

Screenshot 2024-05-27 at 13 08 02
oscarkilhed commented 5 months ago

@dprokop

@oscarkilhed - can we also add some max width constraint to the value input? While editing it (entering custom value) it can push the time controls outside of the container:

Screenshot 2024-05-27 at 13 08 02

Working on this. Apparently it's not that easy to solve. Not sure what's causing the element to grow outside of the parent element.

oscarkilhed commented 5 months ago

Managed to fix the overlap of the remove button and time controls. Seems to have been because the remove button had 0 width.

Will continue working on the controls being pushed outside of the viewport.

oscarkilhed commented 5 months ago

@dprokop I suggest we adress the growing issues in a different PR. I've got a draft PR here that solves the issue.

grafanabot commented 5 months ago

:rocket: PR was released in v4.24.3 :rocket: