search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

AdHocFiltersVariable: Show operator in vertical mode #783

Closed ivanahuckova closed 3 months ago

ivanahuckova commented 3 months ago

This PR adds operator in vertical mode for ad hoc filters.

image image
ivanahuckova commented 3 months ago

I wonder if it should be optional, so it can potentially be hidden in advanced mode

What would be the reason? I am asking because in horizontal mode, it is always visible and you can always change it. And both filter for and filter out are quite typical uses that I think most of the apps would want to support sooner or later.

But of course, I can implement it. Would you just add a new option to AdHocFiltersVariableState, something like hideOperator? And would you implement it in both modes?

torkelo commented 3 months ago

@ivanahuckova

What would be the reason?

Just to keep the UI simple and not take up unnecessary space. For metrics, I am not sure filter out is used that much (so far metrics app has done well without an operator).

But of course, I can implement it. Would you just add a new option to AdHocFiltersVariableState, something like hideOperator? And would you implement it in both modes?

let's skip the option for now, the new design I think will always have operator anyway

grafanabot commented 3 months ago

:rocket: PR was released in v4.32.0 :rocket: