search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

UrlSync: Fixes issue with recent url sync change #793

Closed torkelo closed 3 months ago

torkelo commented 3 months ago

Fixes issue with recent url change.

When URL sync root was not the scene root (which is the case for data trails for now, might change it later).

This fixes the state update from URL logic so that the URL sync root is also synced even when it has a parent.

📦 Published PR as canary version: 5.0.1--canary.793.9496367270.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.0.1--canary.793.9496367270.0 npm install @grafana/scenes@5.0.1--canary.793.9496367270.0 # or yarn add @grafana/scenes-react@5.0.1--canary.793.9496367270.0 yarn add @grafana/scenes@5.0.1--canary.793.9496367270.0 ```
torkelo commented 3 months ago

@dprokop

Out of curiosity, did you change the #XXX properties to regular private ones due to the generated code impact, or there was some functional limitations?

Only because the generated code made debugging much harder

grafanabot commented 3 months ago

:rocket: PR was released in v5.0.1 :rocket: