search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

VariableValueSelect: Hardcode flaky Select option e2e-selector #797

Closed Sergej-Vlasov closed 3 months ago

Sergej-Vlasov commented 3 months ago

One of the selectors from @grafana/e2e-selectors seems to be pulling old version from v10.4 while v11 is specified in deps. Investigating if standartising all versions to v11 will solve this (it did not). Hardcoding for the time being

📦 Published PR as canary version: 5.1.1--canary.797.9578358670.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.1.1--canary.797.9578358670.0 npm install @grafana/scenes@5.1.1--canary.797.9578358670.0 # or yarn add @grafana/scenes-react@5.1.1--canary.797.9578358670.0 yarn add @grafana/scenes@5.1.1--canary.797.9578358670.0 ```
dprokop commented 3 months ago

Think the problem is with @grafana/* packages, which are ^10.4.1:

❯ yarn why @grafana/e2e-selectors
├─ @grafana/e2e@npm:9.2.1
│  └─ @grafana/e2e-selectors@npm:9.2.1 (via npm:9.2.1)
│
├─ @grafana/runtime@npm:10.4.1
│  └─ @grafana/e2e-selectors@npm:10.4.1 (via npm:10.4.1)
│
├─ @grafana/runtime@npm:10.4.1 [47b2b]
│  └─ @grafana/e2e-selectors@npm:10.4.1 (via npm:10.4.1)
│
├─ @grafana/scenes-react@workspace:packages/scenes-react [47b2b]
│  └─ @grafana/e2e-selectors@npm:10.4.3 (via npm:^10.4.1)
│
├─ @grafana/scenes-react@workspace:packages/scenes-react [51613]
│  └─ @grafana/e2e-selectors@npm:10.4.3 (via npm:^10.4.1)
│
├─ @grafana/scenes-react@workspace:packages/scenes-react
│  └─ @grafana/e2e-selectors@npm:10.4.3 (via npm:^10.4.1)
│
├─ @grafana/scenes@workspace:packages/scenes [0b0c4]
│  └─ @grafana/e2e-selectors@npm:11.0.0 (via npm:^11.0.0)
│
├─ @grafana/scenes@workspace:packages/scenes [47b2b]
│  └─ @grafana/e2e-selectors@npm:11.0.0 (via npm:^11.0.0)
│
├─ @grafana/scenes@workspace:packages/scenes [51613]
│  └─ @grafana/e2e-selectors@npm:11.0.0 (via npm:^11.0.0)
│
├─ @grafana/scenes@workspace:packages/scenes
│  └─ @grafana/e2e-selectors@npm:11.0.0 (via npm:^11.0.0)
│
├─ @grafana/ui@npm:10.4.1
│  └─ @grafana/e2e-selectors@npm:10.4.1 (via npm:10.4.1)
│
├─ @grafana/ui@npm:10.4.1 [47b2b]
│  └─ @grafana/e2e-selectors@npm:10.4.1 (via npm:10.4.1)
│
└─ scenes-app@workspace:packages/scenes-app
   └─ @grafana/e2e-selectors@npm:10.4.1 (via npm:10.4.1)
dprokop commented 3 months ago

i see now, v11 won't solve this as the change is targeted at 11.1.x which has not been yet released.

Sergej-Vlasov commented 3 months ago

i see now, v11 won't solve this as the change is targeted at 11.1.x which has not been yet released.

@dprokop The weird thing is that new selector was working for some time and then the old one started pulling through again...
I was planning on updating grafana dependencies to v11 after e2e work so will see, maybe that will help.

grafanabot commented 3 months ago

:rocket: PR was released in v5.1.1 :rocket: