search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

Dependencies: Bump grafana packages to v11 #802

Closed Sergej-Vlasov closed 4 months ago

Sergej-Vlasov commented 4 months ago

Bump grafana packages to v11

📦 Published PR as canary version: 5.3.3--canary.802.9757517518.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.3.3--canary.802.9757517518.0 npm install @grafana/scenes@5.3.3--canary.802.9757517518.0 # or yarn add @grafana/scenes-react@5.3.3--canary.802.9757517518.0 yarn add @grafana/scenes@5.3.3--canary.802.9757517518.0 ```
Sergej-Vlasov commented 4 months ago

Can be tested in this draft PR on main

Sergej-Vlasov commented 4 months ago

are we able to bump to 11.1.0? 🤔 it's the latest minor, and will allow us to unskip this test which would have caught a regression 😭

I think we should do that soon in a major release version so that we do not suddenly break projects that rely on v10.4

ashharrison90 commented 4 months ago

are we able to bump to 11.1.0? 🤔 it's the latest minor, and will allow us to unskip this test which would have caught a regression 😭

I think we should do that soon in a major release version so that we do not suddenly break projects that rely on v10.4

i more meant could we change the version in scenes-app from ^11.0.0 to ^11.1.0. cause i think right now, when you yarn install it's getting that version and using it in the tests in scenes. or can we add a separate devDependency for @grafana/ui? 🤔

Sergej-Vlasov commented 4 months ago

are we able to bump to 11.1.0? 🤔 it's the latest minor, and will allow us to unskip this test which would have caught a regression 😭

I think we should do that soon in a major release version so that we do not suddenly break projects that rely on v10.4

i more meant could we change the version in scenes-app from ^11.0.0 to ^11.1.0. cause i think right now, when you yarn install it's getting that version and using it in the tests in scenes. or can we add a separate devDependency for @grafana/ui? 🤔

@ashharrison90 I tried to update scenes-app and scenes-react to v11.1.0 and it produced quite a few typescript and jest errors in dev environment. I am currently short on time to fix that so I could merge this update to v11.0.0 and we could do update to v11.1.0 in a separate PR that will require more adjustments. Does this work for you?

ashharrison90 commented 4 months ago

@Sergej-Vlasov sure 👍

grafanabot commented 4 months ago

:rocket: PR was released in v5.3.7 :rocket: