grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

Revert "SceneRefreshPicker: Fixes url state issue (#784)" #814

Closed dprokop closed 2 months ago

dprokop commented 2 months ago

This reverts commit 54ff3dcbd885a95a0b20dd42152861f91a7e4281.

Reverts https://github.com/grafana/scenes/pull/784 that caused the initially provided refresh picker state to be reset because the lack of refresh query param would make the state fall back to default. That PR introduced a regression in core Dashboards - basically the preserved refresh starte was not respected anymore.

I think we need to handle OFF refresh as null or undefined rather than '' to allow easier differentiation here, but for now I decide to revert it as it only affects scenes-react (WIP).

This is a part of an escalation fix: https://github.com/grafana/support-escalations/issues/11235

📦 Published PR as canary version: 5.3.5--canary.814.9776702793.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.3.5--canary.814.9776702793.0 npm install @grafana/scenes@5.3.5--canary.814.9776702793.0 # or yarn add @grafana/scenes-react@5.3.5--canary.814.9776702793.0 yarn add @grafana/scenes@5.3.5--canary.814.9776702793.0 ```
grafanabot commented 2 months ago

:rocket: PR was released in v5.3.5 :rocket: