note 2: ~working on a test to prevent future regressions now 🤓~ there is already a test for this in AdhocFiltersVariable.test.ts, but it's currently skipped and can't be enabled until scenes moves to @grafana/ui@11.1.0
📦 Published PR as canary version: 5.3.6--canary.815.9779024969.0
:sparkles: Test out this PR locally via:
```bash
npm install @grafana/scenes-react@5.3.6--canary.815.9779024969.0
npm install @grafana/scenes@5.3.6--canary.815.9779024969.0
# or
yarn add @grafana/scenes-react@5.3.6--canary.815.9779024969.0
yarn add @grafana/scenes@5.3.6--canary.815.9779024969.0
```
fixes the display of groups in adhoc filters
we initially regressed this with https://github.com/grafana/scenes/pull/766
this PR does a couple of things:
getAdhocOptionSearcher
instead of trying to reuse the genericgetOptionSearcher
which is typed forVariableOptions
handleOptionGroups
logic toAdHocFilterRenderer
model._getValuesFor
ds.getTagValues
, which returns aMetricFindValue[]
array containing an optional group parameter_getValuesFor
then maps this toSelectableValue[]
but keeps the group parametervalues
inAdHocFilterRenderer
AdHocFilterRenderer
then uses the new option searcher to filter these options down, and callshandleOptionGroups
to group them all together as beforeyou can test this locally before/after by adjusting the adhoc filters demo and providing a custom
getTagValuesProvider
:note: there is a minor styling issue where we're not showing boundaries between groups for virtualized
Select
s. this needs fixing separately in core.note 2: ~working on a test to prevent future regressions now 🤓~ there is already a test for this in
AdhocFiltersVariable.test.ts
, but it's currently skipped and can't be enabled until scenes moves to@grafana/ui@11.1.0
📦 Published PR as canary version:
5.3.6--canary.815.9779024969.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.3.6--canary.815.9779024969.0 npm install @grafana/scenes@5.3.6--canary.815.9779024969.0 # or yarn add @grafana/scenes-react@5.3.6--canary.815.9779024969.0 yarn add @grafana/scenes@5.3.6--canary.815.9779024969.0 ```