search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

Add query variable in react-scenes #818

Closed mdvictor closed 1 month ago

mdvictor commented 2 months ago

Adds the Query Variable type to react-scenes

Depends on https://github.com/grafana/scenes/pull/827

mdvictor commented 2 months ago

Also, maybe we should add a prefix to these variables to delimit them from their scenes counterparts.

torkelo commented 2 months ago

Also, maybe we should add a prefix to these variables to delimit them from their scenes counterparts.

@mdvictor it's own of the reasons we have separate package to allow some name conflicts, personally I really dislike the name conflicts, tried to get help with naming suggestions (around renaming or prefixing / suffixing) but did not get much feedback on options.

mdvictor commented 1 month ago

@torkelo added explicit comparison to check changes both here and in the datasource variable PR

grafanabot commented 1 month ago

:rocket: PR was released in v5.10.1 :rocket: