search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

Make UrlSyncManager non singleton #841

Closed aocenas closed 2 weeks ago

aocenas commented 2 months ago

Fixes: https://github.com/grafana/grafana/issues/93225 This changes the UrlSyncManager to be used as non singleton.

This relies on this grafana PR: https://github.com/grafana/grafana/pull/90759. Also see the whole demo branch for the Sidecar project here https://github.com/grafana/grafana/pull/88797.

This isn't much changes but need some advice on how to approach any possible backward compatibility issues and testing. As there was already some code created with the non singleton use in mind the changes to apps seem minimal. See this draft PR for the Explore Traces app: https://github.com/grafana/explore-traces/pull/102

aocenas commented 2 weeks ago

Created a new PR for this as there were changes that conflict: https://github.com/grafana/scenes/pull/899