grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

WIP: Implement panel title search logic #845

Closed kaydelaney closed 2 days ago

kaydelaney commented 2 months ago

After trying the behavior approach and finding critical limitations(PR), such as:

We have decided to take another chance with implementing the search logic in the scenes library.

This PR introduced new optional properties to SceneGridLayout, the idea is to use this feature toggles in the Grafana repository behind a feature toggle

  /** Panel search */
  showPanelSearch?: boolean;
  searchString?: string;
  panelsPerRow?: number;
📦 Published PR as canary version: 5.15.0--canary.845.11012035874.0
:sparkles: Test out this PR locally via: ```bash npm install @grafana/scenes-react@5.15.0--canary.845.11012035874.0 npm install @grafana/scenes@5.15.0--canary.845.11012035874.0 # or yarn add @grafana/scenes-react@5.15.0--canary.845.11012035874.0 yarn add @grafana/scenes@5.15.0--canary.845.11012035874.0 ```
kaydelaney commented 2 months ago

Is there a way to build this as a behavior or / pluggable feature for the grid? (not sure if that is the case or if it's a good idea, but feels like a non core feature of the grid itself

I agree it really isn't a core feature. I'll try and see if I can think of a way to make it more "modular"

kaydelaney commented 2 months ago

Closing in favor of https://github.com/grafana/grafana/pull/91139

kaydelaney commented 2 days ago

Closing in favor of https://github.com/grafana/grafana/pull/93670