search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
141 stars 21 forks source link

GroupByVariable: Support custom filter keys #865

Closed andreaalopez closed 1 week ago

andreaalopez commented 3 months ago

Allow custom input for GroupByVariable Closes #847

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

torkelo commented 3 months ago

@andreaalopez can you sign CLA?

dprokop commented 2 months ago

@ashharrison90 wasn't there a reason why we didn't enable custom value creation for Group By?

ashharrison90 commented 2 months ago

@ashharrison90 wasn't there a reason why we didn't enable custom value creation for Group By?

@dprokop sorry completely missed this. it used to support it, and we reverted it here. i don't think there's a huge issue with supporting it tbh 🤷 we support custom values on both sides of an adhoc filters which is very similar tbh

ch-plattner commented 2 months ago

Hi, if there are no blockers, we'd love to merge this. Thanks for engaging on this contribution!

ch-plattner commented 1 week ago

@ashharrison90 Thoughts on merging this? I don't have permission to do so

ashharrison90 commented 1 week ago

yeah i think we can just merge 👍

scenes-repo-bot-access-token[bot] commented 1 week ago

:rocket: PR was released in v5.23.3 :rocket: