search

grafana / scenes

Build Grafana dashboards directly in your Grafana app plugins.
https://grafana.com/developers/scenes
Apache License 2.0
133 stars 20 forks source link

Make SceneRefreshPicker respect config.minRefreshInterval #877

Closed oscarkilhed closed 3 weeks ago

oscarkilhed commented 1 month ago

https://github.com/grafana/support-escalations/issues/12157

The refresh picker in scenes does not respect the min_refresh_interval from the config.

This PR makes sure we filter the list of intervals to only include intervals longer than the min config. Also sets the interval to the minimum interval in the list if updated from the URL with a bad interval.

oscarkilhed commented 1 month ago

@torkelo Hmm that's a good point. There's a few options I guess. Either we enforce it for all apps and dashboards, or we default to the config value for apps and dashboards but let apps override it, or we let the dashboards and apps handle it independently. I think the safes would probably be option 2, to let apps override it but default to the config.

torkelo commented 1 month ago

@oscarkilhed that is a good option, by default filter based on this setting (for both dashboards and scene apps) , but let scene apps override it

oscarkilhed commented 3 weeks ago

Updated to allow overriding the minRefreshInterval

grafanabot commented 3 weeks ago

:rocket: PR was released in v5.11.2 :rocket: